main: Move pending-input check before region_highlight reset#976
Open
rosborn wants to merge 1 commit intozsh-users:masterfrom
Open
main: Move pending-input check before region_highlight reset#976rosborn wants to merge 1 commit intozsh-users:masterfrom
rosborn wants to merge 1 commit intozsh-users:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using cursor-click-to-move in ghostty, the syntax highlighting was being cleared while the cursor was being moved. See ghostty-org/ghostty#11750.
I managed to trace it down to zsh-syntax-highlighting clearing region_highlight before checking that there is pending input. When the terminal sends a rapid sequence of arrow keys, each keystroke triggers _zsh_highlight, which clears the highlights, detects more keys in the queue, and returns.
The fix moves the pending-input check before the region_highlight reset so that existing highlights are preserved.