Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml SETTINGS_ env var family typo #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dearlordylord
Copy link

@dearlordylord dearlordylord commented Jan 29, 2025

SETTINGS_ prefixed env vars don't end up in settings

I believe you meant SETTING_ : those properly end up in settings

e.g. bucket names ain't empty when I run docker exec -u zulip -it docker-zulip-zulip-1 bash -l -c "/home/zulip/deployments/current/manage.py transfer_uploads_to_s3"

Fixes: ?

How did you test this PR?

transfer_uploads_to_s3 script works now

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant