Skip to content

bots: migrate to new bs4 API #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

bots: migrate to new bs4 API #868

merged 1 commit into from
May 6, 2025
+1 −1

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 2, 2025 •
edited
Loading

PR Summary

Small PR - resolves the bs4 deprecation warnings which you can see in the CI logs:

  /home/runner/work/python-zulip-api/python-zulip-api/zulip_bots/zulip_bots/bots/google_search/google_search.py:21: DeprecationWarning: Call to deprecated method findAll. (Replaced by find_all) -- Deprecated since version 4.0.0.
    anchors = search.findAll("a")

@emmanuel-ferdman
bots: migrate to new bs4 API
e0448e7 
Signed-off-by: Emmanuel Ferdman <[email protected]>
@timabbott timabbott merged commit 445ea13 into zulip:main May 6, 2025
13 of 14 checks passed
@timabbott
Copy link
Member

Great, merged, thanks @emmanuel-ferdman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmanuel-ferdman @timabbott @zulipbot