Skip to content

Conversation

Niloth-p
Copy link
Contributor

@Niloth-p Niloth-p commented Jun 5, 2025

Screenshots

SVN doc link
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Copy link

@laurynmm laurynmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Niloth-p - Thanks for updating this doc! Overall, these updates look good. Posted a few review comments; let me know if you have any questions!

Copy link
Contributor Author

@Niloth-p Niloth-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! Updated as recommended.
I've not made any changes related to the existence of the target channel, as I'm unsure how to proceed.
I've switched to using backticks instead of double quotes for channel names, and added the prefix # in front of channel names (because that's the convention in the Help docs - example), based on your review comment on another doc PR.

Screenshot

image

@Niloth-p
Copy link
Contributor Author

Niloth-p commented Jul 2, 2025

I've switched to using bold formatting instead of backticks for channel names.

Screenshot

image

@alya
Copy link
Contributor

alya commented Oct 3, 2025

The screenshot looks like really outdated Zulip UI.

@alya
Copy link
Contributor

alya commented Oct 3, 2025

@laurynmm Do you have any further feedback?

@alya alya added the maintainer review PR is ready for review by Zulip maintainers. label Oct 3, 2025
@Niloth-p
Copy link
Contributor Author

Niloth-p commented Oct 4, 2025

The screenshot looks like really outdated Zulip UI.

That should now be updated by the example screenshots PR that was merged yesterday. 😄

However, I just noticed that this actually requires a prior PR that adds the macro install-requirements.md in the other repo; I'll have to check if it's included in another PR, and link it as a prerequisite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR is ready for review by Zulip maintainers. size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants