-
-
Notifications
You must be signed in to change notification settings - Fork 394
integration-docs: Update the SVN integration doc. #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Niloth-p - Thanks for updating this doc! Overall, these updates look good. Posted a few review comments; let me know if you have any questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! Updated as recommended.
I've not made any changes related to the existence of the target channel, as I'm unsure how to proceed.
I've switched to using backticks instead of double quotes for channel names, and added the prefix #
in front of channel names (because that's the convention in the Help docs - example), based on your review comment on another doc PR.
The screenshot looks like really outdated Zulip UI. |
@laurynmm Do you have any further feedback? |
That should now be updated by the example screenshots PR that was merged yesterday. 😄 However, I just noticed that this actually requires a prior PR that adds the macro |
Screenshots
SVN doc link

Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: