Upgrade dependencies, including Electron 25.2.0. #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought this would fix zulip#1315, but it did not. Hopefully the contribution will still be useful. Test plan: ``` $ npm test > [email protected] test > tsc && npm run lint-html && npm run lint-css && npm run lint-js && npm run prettier-non-js > [email protected] lint-html > htmlhint "app/**/*.html" Config loaded: /home/pounce/programming/zulip-desktop/.htmlhintrc Scanned 4 files, no errors found (13 ms). > [email protected] lint-css > stylelint "app/**/*.css" > [email protected] lint-js > xo > [email protected] prettier-non-js > prettier --check --loglevel=warn . "!**/*.{js,ts}" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this would fix #1315, but it did not. Hopefully the contribution will still be useful.
The
Eventtype now has to be manually imported from electron, as it is mistakenly picked up from Node in the newest version. This is the only meaningful change in the zulip client.Test plan:
What's this PR do?
Upgrades electron
You have tested this PR on: