Skip to content

Notify user when DMing a guest, based on setting #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gnprice opened this issue Jul 10, 2024 · 7 comments · May be fixed by #1477
Open

Notify user when DMing a guest, based on setting #798

gnprice opened this issue Jul 10, 2024 · 7 comments · May be fixed by #1477
Assignees
@chimnayajith
Labels
a-compose Compose box, autocomplete, attaching files/images help wanted server-10 Things new in Zulip Server 10.0
Milestone
M5b: Launch goals

Comments

@gnprice
Copy link
Member

gnprice commented Jul 10, 2024 •
edited
Loading

This is the zulip-flutter side of the following upcoming Zulip feature, with corresponding server/web and zulip-mobile issues:

The feature is probably landing in Zulip Server 9.0, so it'd be good to implement soon. That means:

  • consume that new setting from the server;
  • when appropriate, show a banner above the compose box similar to the one shown in Zulip web and zulip-mobile.

References
@gnprice gnprice added a-compose Compose box, autocomplete, attaching files/images server-9 Things new in Zulip Server 9.0 labels Jul 10, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jul 10, 2024
@gnprice gnprice mentioned this issue Jul 10, 2024
Closed
@alya alya mentioned this issue Jul 10, 2024
Open
1 task
@gnprice gnprice modified the milestones: Beta 4: Fall 2024, Launch Nov 21, 2024
@gnprice gnprice added server-10 Things new in Zulip Server 10.0 and removed server-9 Things new in Zulip Server 9.0 labels Nov 21, 2024
@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
@gnprice
Copy link
Member Author

gnprice commented Feb 6, 2025

This feature just landed in server and web, so it'll be in the upcoming Server 10 release. So that means we will indeed want to have it in time for the launch.

@Abhisheksainii
Copy link

claiming this issue!

@Abhisheksainii
Copy link

@gnprice is it possible that there could be a DM group with all the users being guests?

@gnprice
Copy link
Member Author

gnprice commented Feb 12, 2025

Hmm, I don't follow how that affects this issue.

The #mobile-dev-help channel is a good place to ask questions — more people will see it, and Zulip makes a better venue for back-and-forth discussion than GitHub.

Abhisheksainii added a commit to Abhisheksainii/zulip-flutter that referenced this issue Feb 16, 2025
@Abhisheksainii
message-list : add a prompt to notify guest(s) when DM
0bc4083 
Fixes zulip#798
showDMWarningBanner could be initialized in the initState to shouldShowGuestUserWarningPrompt(store) and Visibility wrapper could have been gotten rid off , but due to unavailability of store beforehand it was not possible.

To create the guests list, I got rid off all the users in the store which are not in the recepients list and role-checked them.
@Abhisheksainii Abhisheksainii mentioned this issue Feb 16, 2025
Closed
Abhisheksainii added a commit to Abhisheksainii/zulip-flutter that referenced this issue Feb 19, 2025
@Abhisheksainii
message-list : add a prompt to notify guest(s) when DM
0dcbc89 
Fixes zulip#798
showDMWarningBanner could be initialized in the initState to shouldShowGuestUserWarningPrompt(store) and Visibility wrapper could have been gotten rid off , but due to unavailability of store beforehand it was not possible.

To create the guests list, I got rid off all the users in the store which are not in the recepients list and role-checked them.
@chimnayajith
Copy link
Contributor

I'd like to work on this.

@AhmedTareek
Copy link

Hello! 😊 I am new to contributing to Zulip, and I would love to have this issue assigned to me. I've already made some progress, which I show in the video below. There are still some refactorings and tests left to do before I can open my first PR for review.

I couldn't find a design for this on Figma, so I tried to follow the description from the issue here: zulip/zulip#30078. If the design needs to be changed, I'm happy to adjust it.

Also, I made the banner appear at the top instead of the bottom to always have a space at the end following this discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Mark-as-read/near/1680603

Screenrecorder-2025-03-06-22-25-05-360.mp4

@gnprice
Copy link
Member Author

gnprice commented Mar 6, 2025

Hello @AhmedTareek, welcome. @chimnayajith is already working on this issue, so I recommend looking around the tracker to find another issue to try.

(I've also just edited the issue description to link to the [design thread](* zulip/zulip#30078
) that @chimnayajith started for this issue.)

@chimnayajith chimnayajith linked a pull request Apr 22, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chimnayajith chimnayajith

Labels
a-compose Compose box, autocomplete, attaching files/images help wanted server-10 Things new in Zulip Server 10.0
Projects
Flutter app
Status: No status
Milestone
M5b: Launch goals
4 participants
@gnprice @chimnayajith @Abhisheksainii @AhmedTareek