message-list : add a prompt to notify guest(s) when DM #1362
Conversation
|
Thanks! Marking as draft since this won't be ready for review until it has tests. For help writing tests, the best place to ask is in Zulip in #mobile-dev-help. |
Fixes zulip#798 showDMWarningBanner could be initialized in the initState to shouldShowGuestUserWarningPrompt(store) and Visibility wrapper could have been gotten rid off , but due to unavailability of store beforehand it was not possible. To create the guests list, I got rid off all the users in the store which are not in the recepients list and role-checked them.
Abhisheksainii
force-pushed
the
feat/notify-dmguest
branch
from
9dbe3e0 to
25c4671
Compare
|
@gnprice I think the PR is ready for review. Let me know if I need to do some changes beforehand. |
|
I'm seeing a lot of changes that don't look related to the work that's needed; please remove those. Also, CI is failing; you'll need to fix that. |
@chrisbobbe it will help a lot if you can mention the changes that seem not required, either here or I can create a topic in mobile-dev-help channel. |
|
For example I see many changes in |
Abhisheksainii
force-pushed
the
feat/notify-dmguest
branch
from
25c4671 to
0dcbc89
Compare
|
@chrisbobbe unnecessary fixes removed and CI checks passed. |
Fixes #798
Changes made:
Add a prompt above composeBox to notify the user if the recipient is a guest or not. Attaching screenshots and video for reference.
WhatsApp.Video.2025-02-16.at.13.08.40.mp4