Skip to content

msglist: Move star icon 2px away from the edge of the screen #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

msglist: Move star icon 2px away from the edge of the screen #1249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lib/widgets/message_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import 'dart:math';
import 'package:collection/collection.dart';
import 'package:flutter/material.dart';
import 'package:flutter_color_models/flutter_color_models.dart';
import 'package:intl/intl.dart';
import 'package:intl/intl.dart' hide TextDirection;

import '../api/model/model.dart';
import '../generated/l10n/zulip_localizations.dart';
Expand Down Expand Up @@ -1387,6 +1387,17 @@ class MessageWithPossibleSender extends StatelessWidget {
case MessageEditState.none:
}

Widget? star;
if (message.flags.contains(MessageFlag.starred)) {
final starOffset = switch (Directionality.of(context)) {
TextDirection.ltr => -2.0,
TextDirection.rtl => 2.0,
};
star = Transform.translate(
offset: Offset(starOffset, 0),
child: Icon(ZulipIcons.star_filled, size: 16, color: designVariables.star));
}

return GestureDetector(
behavior: HitTestBehavior.translucent,
onLongPress: () => showMessageActionSheet(context: context, message: message),
Expand Down Expand Up @@ -1418,9 +1429,7 @@ class MessageWithPossibleSender extends StatelessWidget {
context, 0.05, baseFontSize: 12))),
])),
SizedBox(width: 16,
child: message.flags.contains(MessageFlag.starred)
? Icon(ZulipIcons.star_filled, size: 16, color: designVariables.star)
: null),
child: star),
]),
])));
}
Expand Down
Loading