Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist: Fix channel header tap behaviour in multi-channel narrows #1370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

msglist: Fix channel header tap behaviour in multi-channel narrows #1370

wants to merge 1 commit into from
+105 −0

Conversation

E-m-i-n-e-n-c-e
Copy link
Contributor

@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e commented Feb 21, 2025 •
edited
Loading

Description

This PR fixes the channel header navigation in multi-channel narrows

Changes

  • Modified the GestureDetector in StreamMessageRecipientHeader to use HitTestBehavior.opaque
  • Added a test that verifies tapping 1 px below the top of the recipient header, and 1 px above the bottom of it in the channel name area navigates to the channel feed
  • Also added a test that verifies tapping 1 px below the top of the recipient header, and 1 px above the bottom of it in the topic name area navigates to the topic feed

Related Issues:

Closes #1179

I have verified that the test fails before the changes and the test passes after the changes

@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e force-pushed the 1368 branch 3 times, most recently from 431f1cd to 81c835a Compare February 21, 2025 16:04
@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e mentioned this pull request Feb 22, 2025
Open
@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e changed the title combined feed: Fix channel header tap behaviour in combined feed combined feed: Fix channel header tap behaviour in multi-channel narrows Feb 24, 2025
@E-m-i-n-e-n-c-e
Copy link
Contributor Author

Chat thread

@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e force-pushed the 1368 branch 2 times, most recently from 4ab7f1b to 5f22c99 Compare February 25, 2025 08:22
@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e changed the title combined feed: Fix channel header tap behaviour in multi-channel narrows msglist: Fix channel header tap behaviour in multi-channel narrows Feb 25, 2025
@E-m-i-n-e-n-c-e
msglist: Fix channel header tap behaviour in multi-channel narrows
57e46a7 
Set gesture detecter behavior of streamWidget to HitTestBehavior.opaque
to handle taps in empty space around the header.

Also added two tests to verify the behaviour

Fixes zulip#1368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tap target for channel in recipient header is shorter than header
1 participant
@E-m-i-n-e-n-c-e