Skip to content

msglist: Show list of topics in channel #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

E-m-i-n-e-n-c-e
Copy link
Contributor

I have implemented all the required features for #1158 . Will implement the exact design once there is a Figma design for the topic list page

WhatsApp.Video.2025-02-26.at.17.06.49_5893406d.mp4

Closes #1158

Add "Show topics" button tooltip and "Search topics" placeholder text
to all language files (English, Slovak, Norwegian, Polish, Russian,
Arabic, and Japanese).

Fixes part of zulip#1158.
@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e force-pushed the 1158 branch 2 times, most recently from 267f8e1 to 6aa6995 Compare February 26, 2025 16:09
This commit creates a new topic list page showing all topics in
current channel with search functionality ordered by recency

Also adds a button to app bar actions in message list page which
appears in channel narrows and navigates to the topic list page
when pressed

Fixes zulip#1158.
@E-m-i-n-e-n-c-e
Copy link
Contributor Author

Added three tests:

  • navigates to TopicListPage on tapping topic list button in ChannelNarrow
  • live updates topic list when new message is added
  • navigates to topic narrow on tapping topic in TopicListPage

@lakshya1goel
Copy link
Contributor

lakshya1goel commented Feb 27, 2025

Hi @E-m-i-n-e-n-c-e , I believe the design for this issue hasn’t been finalized yet. You can check the discussion here: #mobile-design > Topic list in channel. I was interested in working on this issue and have been waiting for the designs to be finalized, which is why I asked about it in CZO.

@E-m-i-n-e-n-c-e
Copy link
Contributor Author

Hi @E-m-i-n-e-n-c-e , I believe the design for this issue hasn’t been finalized yet. You can check the discussion here: #mobile-design > Topic list in channel. I was interested in working on this issue and have been waiting for the designs to be finalized, which is why I asked about it in CZO.

Sorry about that! I didn't see any PRs or commits for this issue before starting work. Only checked the design discussions after submitting my PR.

I can continue with what I've built so far, or step back if you've already made progress on it. Let's wait for the thoughts of a core contributor on how to proceed.

@gnprice
Copy link
Member

gnprice commented Feb 28, 2025

Yeah, let's plan for @lakshya1goel to handle this issue #1158, since she's been in that thread ready and explicitly awaiting the design. (I think the design will be ready sometime soon.)

I'll update #1158 to make the status clear and link that design thread.

@gnprice gnprice closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of topics in channel
3 participants