ios build: Take auto updates to Podfile.lock and an Xcode file #1444
Conversation
|
(Ah, I suggested "ios build" as a summary-line prefix because I was thinking of the Xcode config changes as a separate commit. I agree with your first thought that "ios deps" is a good prefix for the Podfile.lock changes.) |
| @@ -26,6 +26,7 @@ | |||
| buildConfiguration = "Debug" | |||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | |||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | |||
| customLLDBInitFile = "$(SRCROOT)/Flutter/ephemeral/flutter_lldbinit" | |||
There was a problem hiding this comment.
Looking at this line more closely, the content of it sounds like something the flutter tool might put there.
And indeed, git log -G flutter_lldbinit in the Flutter tree finds this from earlier this month, 2025-03-06:
flutter/flutter@eb07c51
So this is a side effect of the Flutter upgrade in #1426.
There was a problem hiding this comment.
There was a problem hiding this comment.
Cool, makes sense.
And yeah, agreed on both points re #773.
There was a problem hiding this comment.
Made a note of that on #773, and bumped it up to M5b (from M6).
Greg found that this is a side effect of the Flutter upgrade in PR zulip#1426: zulip#1444 (comment) > And indeed, `git log -G flutter_lldbinit` in the Flutter tree > finds this from earlier this month, 2025-03-06: > flutter/flutter@eb07c5123 Committing it here, after building for iOS, which we forgot to do when preparing that PR.
These are needed because zulip#1426 didn't include the `pod` step of `tools/upgrade`. Done by building for iOS, then (when I remembered that macOS/Podfile.lock needs updating too) `tools/upgrade pod`.
chrisbobbe
force-pushed
the
pr-podfile-xcode-file-auto-updates
branch
from
0dd9eda to
16e4d88
Compare
|
Thanks for the reviews! Revision pushed. |
|
Thanks both! Looks good; merging. |
I think the Podfile.lock changes are needed because #1426 didn't include the
podstep oftools/upgrade.I suspect the Xcode-file update is due to an Xcode upgrade.
Done by building for iOS, with Xcode 16.2 (16C5032a), then (when I remembered that macOS/Podfile.lock needs updating too)
tools/upgrade pod.cc @rajveermalviya as the author of #1426.