channel: Maintain maps consistently when removing subscriptions #1479
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
approved these changes
Apr 24, 2025
chrisbobbe
added
integration review
gnprice
reviewed
Apr 25, 2025
test/model/channel_test.dart
Outdated
| @@ -68,6 +68,22 @@ void main() { | |||
| )); | |||
| checkUnified(store); | |||
| }); | |||
|
|
|||
| test('removed then added by events', () async { | |||
There was a problem hiding this comment.
Suggested change
| test('removed then added by events', () async { | |
| test('unsubscribed then subscribed by events', () async { |
The group is about "stream/sub data" in general, so this otherwise sounds like it's probably about removing the whole stream.
There was a problem hiding this comment.
Separately, since this is a regression test for a particular bug that we actually had, let's link that context:
Suggested change
| test('removed then added by events', () async { | |
| test('removed then added by events', () async { | |
| // Regression test for: https://chat.zulip.org/#narrow/channel/48-mobile/topic/Unsubscribe.20then.20resubscribe.20to.20channel/with/2160241 |
|
Thanks! Updated the PR. |
When a subscription is removed, the data in streams and streamsByName are left as instances of `Subscription`. This is inconsistent with the data store's assumption that unsubscribed channels should have plain `ZulipStream` instances. This doesn't seem to have user-facing effects, though. The assertion errors only affect debug builds. CZO discussion: https://chat.zulip.org/#narrow/channel/48-mobile/topic/Unsubscribe.20then.20resubscribe.20to.20channel/with/2160241
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subscription is removed, the data in streams and streamsByName are left as instances of
Subscription. This is inconsistent with the data store's assumption that unsubscribed channels should have plainZulipStreaminstances.This doesn't seem to have user-facing effects, though. The assertion errors only affect debug builds.
CZO discussion:
https://chat.zulip.org/#narrow/channel/48-mobile/topic/Unsubscribe.20then.20resubscribe.20to.20channel/with/2160241