KaTeX(7/n): Handle 'op-limits' KaTeX CSS #1669
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And inline the behaviour for `inline: false` in MathBlock widget.
This applies the correct font scaling if the KaTeX content is inside a header.
In KaTeX HTML it is used to set the baseline of the content in a span, so handle it separately here.
Implement handling most common types of `vlist` spans.
Negative margin spans on web render to the offset being applied to the specific span and all the adjacent spans, so mimic the same behaviour here.
This matches the katex.scss here: https://github.com/KaTeX/KaTeX/blob/613c3da85/src/styles/katex.scss#L629
This will be use in later commits to apply styles based on some preconditions that depend on a class being present on an ancestor.
…Stack` This allows the children in the vlist to expand horizontally as wide as their siblings. That will enable support for vlist's children to be center aligned if they had (or inherited) a `text-align: center`.
|
The difference ends up being that
( 
|
|
Thanks for building this! See my comments on #1670 for a few things I'd like to see on all the open KaTeX PRs: #1670 (review), #1670 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1559.
Currently a draft because there are some vertical offset differences in the tests, after f10a078 that I still need to figure out. But otherwise when seeing the content side-by-side with Web, I wasn't able to see any differences.