Prep for user-group autocomplete #1745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like we do in emoji autocomplete. This commit doesn't make any changes to the results ordering; bucketSort sorts stably, and the input is still just the wildcard results followed by the user results. Soon, though, we'd like to rank by match quality and add user-group results (for zulip#233) interleaved with user results. Bucket sorting will help us do this without making many intermediate copies of lists of results; see discussion: https://chat.zulip.org/#narrow/channel/48-mobile/topic/user-group.20mentions.20.23F233/near/2216353
chrisbobbe
added
the
integration review
gnprice
reviewed
Jul 24, 2025
Comment on lines
+775
to
+779
| /// A measure of a wildcard result's quality in the context of the query, | ||
| /// from 0 (best) to one less than [_numResultRanks]. | ||
| /// | ||
| /// See also [_rankUserResult]. | ||
| static const _rankWildcardResult = 0; |
There was a problem hiding this comment.
This name is a verb phrase (well, it could be extra elliptical and mean "the rank for a wildcard result", but I want to read it as a verb phrase: "rank a wildcard result"), so it's a bit odd for it to be a constant value.
Maybe go ahead and make it a function that returns a constant? That'll better demonstrate the future structure you intend anyway.
Sent as #1748 — please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three commits add a
rankfield toMentionAutocompleteResult, simply choosing 0 for wildcard results and 1 for user results, and abucketSorton that new field. This is to prepare for more complicated ranking, with more ranks:Discussion: #mobile > user-group mentions #F233 @ 💬
@gnprice, I'm curious how you'd like the tests to change, to support that more complicated ranking. Would you be up for demonstrating that by writing a few commits? I think you could do that by converting the
compareByBotStatuslogic into the new bucket-sort-by-rank logic. If we're following web (sort_recipientsin web/src/typeahead_helper.ts), then some user-group results will need to be interleaved between human- and bot-user results, which calls for humans and bots to be in different buckets. As a first step, I think we'd go from two ranks (wildcard then users) to three ranks (wildcard then humans then bots); is that right?