startup: Add beta-complete dialog #1797

chrisbobbe · 2025-08-08T22:26:39Z

Fixes #1603.

cc @alya

alya · 2025-08-09T00:11:54Z

The screenshots look good to me!

It's a bit annoying that the heading might not fit on one line, but I think it's all right.

gnprice

Thanks for taking care of this! Generally looks good; mostly small comments.

gnprice · 2025-08-15T23:34:44Z

lib/widgets/dialog.dart

+  unawaited(showDialog(
+    context: context,
+    builder: (BuildContext context) => AlertDialog(
+      title: Text('Time to switch to the new app'),
+      content: SingleChildScrollView(child: Text(message)),
+      actions: [


nit: I like the structure I found for the welcome dialog (0e34d96 / #1590):

turn this builder callback into the build method of a widget;

then the logic above the showDialog call (well, except for a couple of locals that are part of the build logic) becomes a static method on that widget — so e.g. BetaCompleteDialog.show().

In particular that gives the build callback a bit more room to breathe, and separates it from the one-time logic that decides when and whether to show it.

gnprice · 2025-08-15T23:37:11Z

lib/widgets/dialog.dart

+              TextButton(
+                onPressed: () {
+                  Navigator.pop(context);
+                  PlatformActions.launchUrl(context,
+                    Uri.parse('https://github.com/zulip/zulip-flutter/releases/latest'));
+                },
+                child: _dialogActionText('Download official APKs (less common)')),


nit: These three very similar items can be made easier to read with a helper method; e.g.,

Suggested change

TextButton(

onPressed: () {

Navigator.pop(context);

PlatformActions.launchUrl(context,

Uri.parse('https://github.com/zulip/zulip-flutter/releases/latest'));

},

child: _dialogActionText('Download official APKs (less common)')),

_linkButton(

url: 'https://github.com/zulip/zulip-flutter/releases/latest',

label: 'Download official APKs (less common)'),

gnprice · 2025-08-15T23:39:42Z

lib/widgets/dialog.dart

+
+  final zulipLocalizations = ZulipLocalizations.of(context);
+
+  final message = 'Since Zulip’s new Flutter app has launched, this beta app is no longer maintained. We strongly recommend uninstalling it and switching to the main Zulip application to get the latest features and bug fixes. Thank you for being a beta tester!';


nit: wrap for readability

Suggested change

final message = 'Since Zulip’s new Flutter app has launched, this beta app is no longer maintained. We strongly recommend uninstalling it and switching to the main Zulip application to get the latest features and bug fixes. Thank you for being a beta tester!';

final message = 'Since Zulip’s new Flutter app has launched,'

' this beta app is no longer maintained.'

' We strongly recommend uninstalling it and switching to the'

' main Zulip application to get the latest features and bug fixes.'

' Thank you for being a beta tester!';

(handy tip in Android Studio / IntelliJ: with cursor in the middle of a string literal, hit enter — that will insert the close-quote and open-quote to split the string, too)

Thanks for that tip, it worked great!

gnprice · 2025-08-15T23:49:58Z

lib/widgets/dialog.dart

+
+  final zulipLocalizations = ZulipLocalizations.of(context);
+
+  final message = 'Since Zulip’s new Flutter app has launched, this beta app is no longer maintained. We strongly recommend uninstalling it and switching to the main Zulip application to get the latest features and bug fixes. Thank you for being a beta tester!';


For the text here, how about:

Thanks for being a beta tester of the new Zulip app! This app became the main Zulip mobile app in June 2025, and this beta version is no longer maintained. We recommend uninstalling this beta after switching to the main Zulip app, in order to get the latest features and bug fixes.

gnprice · 2025-08-15T23:51:58Z

lib/widgets/dialog.dart

@@ -112,3 +116,75 @@ DialogStatus<bool> showSuggestedActionDialog({
      ]));
  return DialogStatus(future);
 }
+
+bool debugDisableBetaCompleteDialog = false;
+void resetDebugDisableBetaCompleteDialog() {


nit: this should also start with "debug", as it's meant to be called only in debug mode

gnprice · 2025-08-15T23:52:30Z

test/notifications/open_test.dart

+    debugDisableBetaCompleteDialog = true;
+    addTearDown(resetDebugDisableBetaCompleteDialog);


nit: alternatively, could dispense with the separate "reset" method:

Suggested change

debugDisableBetaCompleteDialog = true;

addTearDown(resetDebugDisableBetaCompleteDialog);

debugDisableBetaCompleteDialog = true;

addTearDown(() => debugDisableBetaCompleteDialog = false);

gnprice · 2025-08-15T23:56:15Z

test/widgets/message_list_test.dart

+    debugDisableBetaCompleteDialog = true;
+    addTearDown(resetDebugDisableBetaCompleteDialog);


nit: are these needed? I don't see ZulipApp used in this file

chrisbobbe · 2025-08-16T00:32:06Z

Thanks for the review! Revision pushed, and here's a screenshot with the new text:

This is a cherry-pick of d6affc9 from the main branch.

gnprice

Thanks! Looks good.

One nit; and I'm also pushing a commit to try to get CI working:
0190b1f ci: Fetch 3000 commits from upstream, rather than 1000

gnprice · 2025-08-16T00:46:56Z

lib/widgets/dialog.dart

+  Widget _linkButton(BuildContext context, {required String url, required String label}) =>
+    TextButton(


nit: use block body for a multi-line definition like this

chrisbobbe · 2025-08-16T00:58:36Z

Thanks! Fixed that nit.

gnprice · 2025-08-16T01:15:08Z

CI failed with one lint issue and 5 test failures.

At least some of those are due to using the latest upstream Flutter. So let's switch ci.yml in this branch to instead pin the same Flutter version that's in pubspec.yaml.

To avoid one lint issue and 5 test failures that would happen if using the latest main.

Fixes zulip#1603.

chrisbobbe requested a review from gnprice August 8, 2025 22:26

chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Aug 15, 2025

chrisbobbe assigned gnprice Aug 15, 2025

gnprice reviewed Aug 15, 2025

View reviewed changes

chrisbobbe force-pushed the pr-beta-complete-dialog branch from 8685f9a to bbf6413 Compare August 16, 2025 00:31

ci: Fetch 3000 commits from upstream, rather than 1000

0190b1f

This is a cherry-pick of d6affc9 from the main branch.

gnprice reviewed Aug 16, 2025

View reviewed changes

gnprice force-pushed the pr-beta-complete-dialog branch from bbf6413 to 6ead9e8 Compare August 16, 2025 00:52

chrisbobbe force-pushed the pr-beta-complete-dialog branch from 6ead9e8 to 8986236 Compare August 16, 2025 00:58

chrisbobbe force-pushed the pr-beta-complete-dialog branch 4 times, most recently from 2ba4e8d to 70eb175 Compare August 16, 2025 02:02

chrisbobbe added 2 commits August 15, 2025 19:07

ci: Pin Flutter commit to the one in pubspec.yaml

cd53b81

To avoid one lint issue and 5 test failures that would happen if using the latest main.

startup: Add beta-complete dialog

fd5138b

Fixes zulip#1603.

chrisbobbe force-pushed the pr-beta-complete-dialog branch from 70eb175 to fd5138b Compare August 16, 2025 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

startup: Add beta-complete dialog #1797

startup: Add beta-complete dialog #1797

Uh oh!

chrisbobbe commented Aug 8, 2025

Uh oh!

alya commented Aug 9, 2025 •

edited

Loading

Uh oh!

gnprice left a comment

Uh oh!

gnprice Aug 15, 2025

Uh oh!

gnprice Aug 15, 2025

Uh oh!

gnprice Aug 15, 2025

Uh oh!

chrisbobbe Aug 16, 2025

Uh oh!

gnprice Aug 15, 2025

Uh oh!

gnprice Aug 15, 2025

Uh oh!

gnprice Aug 15, 2025

Uh oh!

gnprice Aug 15, 2025

Uh oh!

chrisbobbe commented Aug 16, 2025

Uh oh!

gnprice left a comment •

edited

Loading

Uh oh!

gnprice Aug 16, 2025

Uh oh!

chrisbobbe commented Aug 16, 2025

Uh oh!

gnprice commented Aug 16, 2025

Uh oh!

Uh oh!


		final zulipLocalizations = ZulipLocalizations.of(context);

		final message = 'Since Zulip’s new Flutter app has launched, this beta app is no longer maintained. We strongly recommend uninstalling it and switching to the main Zulip application to get the latest features and bug fixes. Thank you for being a beta tester!';

-  final message = 'Since Zulip’s new Flutter app has launched, this beta app is no longer maintained. We strongly recommend uninstalling it and switching to the main Zulip application to get the latest features and bug fixes. Thank you for being a beta tester!';
+  final message = 'Since Zulip’s new Flutter app has launched,'
+    ' this beta app is no longer maintained.'
+    ' We strongly recommend uninstalling it and switching to the'
+    ' main Zulip application to get the latest features and bug fixes.'
+    ' Thank you for being a beta tester!';

		debugDisableBetaCompleteDialog = true;
		addTearDown(resetDebugDisableBetaCompleteDialog);

		Widget _linkButton(BuildContext context, {required String url, required String label}) =>
		TextButton(

startup: Add beta-complete dialog #1797

Are you sure you want to change the base?

startup: Add beta-complete dialog #1797

Uh oh!

Conversation

chrisbobbe commented Aug 8, 2025

cc @alya

Uh oh!

alya commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnprice left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisbobbe commented Aug 16, 2025

Uh oh!

gnprice left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisbobbe commented Aug 16, 2025

Uh oh!

gnprice commented Aug 16, 2025

Uh oh!

Uh oh!

alya commented Aug 9, 2025 •

edited

Loading

gnprice left a comment •

edited

Loading