Ensure self-user always present #1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the next few commits, we'll ensure that all tests' data put the self-user in the users list of the initial snapshot. This will help by making that happen automatically for the majority of tests.
This completes the sweep through the tests to ensure the self-user is always found in the list of users in the initial snapshot, like it would be in a real-life initial snapshot from a Zulip server. Upcoming commits will start checking that expectation in the model code.
We'll need to pass RealmStoreImpl some details of the self-user, in order to correctly interpret (for zulip#814) the permissions that live on RealmStore. But because UserStore already depends on RealmStore, we don't want to introduce a dependency in RealmStoreImpl on UserStore as a whole. So separate out the step that processes the user lists, and do that step in advance before constructing RealmStoreImpl.
We'll want to pass this to RealmStoreImpl soon, in order to interpret permissions correctly. In the series of commits leading up to here, we've already adapted all the tests' data to satisfy this invariant.
This is already guaranteed by PerAccountStore.fromInitialSnapshot, the only caller of this constructor.
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes here are all in tests. The last few commits make a small refactor to our model code which we'll want for #814, and which starts requiring that the self-user is present in the list of users the server returns in the initial snapshot.
That should always be true according to the API, but previously it was false for the test data in tons of our tests. So the first N commits of the branch fix our test data to make it true there.