Skip to content

share: Support choosing an account, if there are multiple #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rajveermalviya
Copy link
Member

Light Dark
image image

Tests are TODO and will happen as part of #1787 in a follow-up PR.

Fixes: #1779

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Aug 20, 2025

Thanks for building this!

I think my ideal version of this would have a slightly different UX:

  • We don't add a new page, but instead show a modified version of the original page:
    • It has a nullable "currently selected account" state, controlled by a "Choose account" button somewhere like in the app bar
      • The button shows which account is selected, if any, making it persistently visible on the page (this should be helpful for accessibility; relying less on the user's memory/attention)
      • When pressed, the button opens a dialog with a list of accounts to select from
      • Maybe selection initializes to the last-visited account (if any), or maybe the dialog opens automatically at the beginning of the interaction
    • The page shows per-account data for the currently selected account (via PerAccountStoreWidget), or placeholder text if no account is selected.

I've pushed a rough draft of an approach like this, but it has some gaps:

If this approach sounds good, would you PTAL? Several of the commits are just cherry picks from #1802 which is close to merge.

@chrisbobbe chrisbobbe force-pushed the pr-share-switch-account branch from 33b20ce to e38794e Compare August 21, 2025 21:29
@chrisbobbe
Copy link
Collaborator

Pushed with a rebase past #1802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Allow selecting an account when sharing to Zulip from other apps
2 participants