-
Notifications
You must be signed in to change notification settings - Fork 329
Implement permissions check for can-delete-message #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c10f9a
api: Add realm-level restrict-message-deleting fields to InitialSnapshot
chrisbobbe 1225c09
channel: Add per-channel restrict-message-deleting fields
chrisbobbe 772b71d
realm [nfc]: Order updatable realm-setting fields by realm/update_dic…
chrisbobbe dd70226
realm: Add realm-level restrict-message-deleting fields to RealmStore
chrisbobbe db5f9bd
channel: Add isArchived field
chrisbobbe 9c37ed4
initial_snapshot: Fill in SupportedPermissionSettings.fixture.realm
chrisbobbe f978e51
channel [nfc]: Add HasChannelStore for other substores to use
chrisbobbe e5b43df
messages [nfc]: Provide ChannelStore to MessageStore
chrisbobbe 536cbb7
message: Implement selfCanDeleteMessage
chrisbobbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
delete_own_message_policy
and notrealm_delete_own_message_policy
?(Docs only has mention of the former.)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I should add a note that this relies on information that isn't in the current doc; I had to look at zulip/zulip@0cd51f2fe, which removed the entry for
realm_delete_own_message_policy
in the register-response doc.In general there's a pattern for realm attributes where the field in the register response is prefixed with
realm_
but the field in therealm/update_dict
event isn't.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the added note (with the reference to that zulip/zulip commit) appears in a later commit