Fixed TextInput Glitch #4237
Open
Fixed TextInput Glitch #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edited : Added GIFs comparing the changes |
Maskedman99
suggested changes
Oct 21, 2020
When repeatedly pressed on SmartUrlInput , the keyboard would relaunch everytime with each trigger casing a glitch look. Fixed by explicitly blurring the focus on textinput when keyboard is hidden , hence preventing its natural behaviour . Fixes zulip#4233
aryanshridhar
force-pushed
the
TextInputFix
branch
from
f50ff7a to
2dbb6f0
Compare
|
Oh yeah @Maskedman99 , I got to know this later and forgot to make changes here . |
aryanshridhar
commented
Oct 22, 2020
| _keyboardDidHide = () => { | ||
| const { textInputRef } = this; | ||
| if (textInputRef) { | ||
| textInputRef.current.blur(); |
There was a problem hiding this comment.
As of now , the keyboard doesn't hide when the user presses on textinput , instead it maintains its previous state . (As shown in GIF) .
Would love to change according to what makes more sense .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4233
Adding GIFs :
Before
After
Would love an review for it !