[WIP] Use real URL parsing for links in messages #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
force-pushed
the
task-use-urlparsing
branch
from
4996102 to
854a264
Compare
Changes isInternalLink to accept a URL object instead of a string and moves the work of new URL(url, realm) out of the same as a first step to change isInternalLinks.js to use URL object. Related to zulip#4292
Changes getPathsFromUrl to accept URL object and modifies the function calls accordingly. Related to zulip#4292
im-adithya
force-pushed
the
task-use-urlparsing
branch
from
0e565bd to
1fb8afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Till now:
Moves the work of new URL(url, realm) out of isInternalLink and getPathsFromURL functions as a first step to change isInternalLinks.js to use URL object instead of strings.
Issues related to this PR
#4292