Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: bugfix: Use server_timestamp for presences #1376

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Apr 11, 2023

What does this PR do, and why?

We previously relied on local time for determining presence, rather than the returned timestamp.

Outstanding aspect(s)

  • Tests
  • Validate assumptions
  • Potentially split out refactoring
  • Determine aggregate or not, and future of presence
  • Improve presence waiting

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Apr 11, 2023
@neiljp neiljp added bug Something isn't working high priority should be done as soon as possible labels Apr 11, 2023
@neiljp neiljp added this to the Next Release milestone Apr 11, 2023
@neiljp neiljp force-pushed the 2023-04-09-server_timestamp branch from 60fa8f2 to 37e9775 Compare November 3, 2023 03:19
@zulipbot zulipbot added size: M [Automatic label added by zulipbot] and removed size: L [Automatic label added by zulipbot] has conflicts labels Nov 3, 2023
@neiljp neiljp force-pushed the 2023-04-09-server_timestamp branch from 37e9775 to 29746fa Compare May 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority should be done as soon as possible size: M [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants