Enhance the behaviour of Esc
in the Emoji-picker popup
#1491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
Previously, pressing Esc anytime when the emoji picker is in use will exit the popup.
Now, different behaviours are supported depending on the state.
1. Escaping from a non-empty searchbox clears it (This is useful since some other editors support using the
Ctrl l
shortcut to clear the editor, but there's none for the emoji-picker popup).2. Escaping from an empty searchbox closes the popup.
3. Escaping from the emoji list exits you out of the popup, if the selected emoji button was toggled after the last search (Allow users to exit the popup as soon as they have made some changes (either newly selected or newly deselected)).
4. Otherwise, it takes you back to the searchbox and retains the last search text. (the user has not made changes or is still navigating in the emoji picker, so allow them to return to the search box without exiting the popup)
External discussion & connections
Enhance Escape key behaviour in Emoji-Picker popup
How did you test this?
Self-review checklist for each commit