bugfix: model: Avoid KeyError when reading user settings at startup. #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR fixes #1600 .
The application crashes at startup when initializing a
Modelobject. The code tries to read some user settings directly frominitial_data, which contains the payload returned by the Zulip APIPOST /registerendpoint.In Zulip 12.0 (feature level 439), many of these settings were removed from the top level object into the
user_settingsdict.This PR updates the code to retrieve user settings from the
user_settingsobject when it is present ininitial_data.The tests were also updated to include all required user settings under the
user_settingskey when it is present ininitial_data.External discussion & connections
crashes after trying to start for the first timeHow did you test this?
Self-review checklist for each commit