-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and Add OpenProject integration #34028
base: main
Are you sure you want to change the base?
Update and Add OpenProject integration #34028
Conversation
Hello @zulip/server-integrations members, this pull request was labeled with the "area: integrations" label, so you may want to check it out! |
This PR fixes the issues pointed out in #29944. Write a fresh
Other changes:
Do review this PR and let me know if any changes have to be made. |
Thank you for the updates. They are good improvements. When I mentioned writing a "fresh" view.py, I didn't want the next contributor taking any inspiration from the previous view.py. Can you please share the info you gathered or relevant links regarding the default values of parameters like "work package type", "action status", etc.? Use Reminder: https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html I'm wondering if we could drop the "successfully" word, given that it's part of all of the message templates. You also need to ensure coverage - see the failing checks. Ah, I'm seeing that you've noticed some of these yourself. |
cd0d994
to
eb29f36
Compare
eb29f36
to
0f68aeb
Compare
0f68aeb
to
bcf9d6a
Compare
@Niloth-p are there any pending issues or is this pr ready to be merged? |
It's not ready to be merged, there are several rounds of review still pending. |
@Niloth-p Any updates on what needs to be added or fixed for this integration? |
Fixes: #29944
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: