Skip to content

Conversation

@alya
Copy link
Contributor

@alya alya commented Jan 2, 2026

Also remove "Hello"s.

Questions

  1. Should we drop claimWarning and the logic around it? (I never see it in action.)
  2. Why don't I ever see needsReviewWarning (which I'm not sure we need) and updateWarning?

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.94%. Comparing base (d575a9e) to head (40153c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files          22       22           
  Lines        2063     2063           
  Branches      121      121           
=======================================
  Hits         1381     1381           
  Misses        680      680           
  Partials        2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timabbott timabbott merged commit 85595ad into zulip:main Jan 5, 2026
4 checks passed
@timabbott
Copy link
Member

Merged, thanks @alya! I don't know the answers to either question, I guess we can discuss on chat.zulip.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants