Skip to content

Fix NoSuchElementException in MissingCommonModuleMethodDiagnostic #3636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix NoSuchElementException in MissingCommonModuleMethodDiagnostic #3636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85555dc
Initial plan
Copilot Dec 3, 2025
70e7bdf
Fix NoSuchElementException in MissingCommonModuleMethodDiagnostic
Copilot Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ...github/_1c_syntax/bsl/languageserver/diagnostics/MissingCommonModuleMethodDiagnostic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,9 @@ public class MissingCommonModuleMethodDiagnostic extends AbstractDiagnostic {
public static final String PRIVATE_METHOD_MESSAGE = "privateMethod";
private final LocationRepository locationRepository;

private static String getMethodNameByLocation(ParserRuleContext node, Range range) {
private static Optional<String> getMethodNameByLocation(ParserRuleContext node, Range range) {
return Trees.findTerminalNodeContainsPosition(node, range.getStart())
.map(ParseTree::getText)
.orElseThrow();
.map(ParseTree::getText);
}

@Override
Expand Down Expand Up @@ -88,9 +87,9 @@ private Optional<CallData> getReferenceToMethodCall(SymbolOccurrence symbolOccur
if (methodSymbol.isEmpty()) {
final var location = symbolOccurrence.location();
// Нельзя использовать symbol.getSymbolName(), т.к. имя в нижнем регистре
return Optional.of(
new CallData(mdObject.get().getName(),
getMethodNameByLocation(documentContext.getAst(), location.getRange()),
return getMethodNameByLocation(documentContext.getAst(), location.getRange())
.map(methodName -> new CallData(mdObject.get().getName(),
methodName,
location.getRange(), false, false));
}
// вызовы приватных методов внутри самого модуля пропускаем
Expand Down