Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request for a Noble ICA for Fast USDC has yet to settle - misconfigured host #11013

Open
dckc opened this issue Feb 18, 2025 · 3 comments · May be fixed by #11060
Open

request for a Noble ICA for Fast USDC has yet to settle - misconfigured host #11013

dckc opened this issue Feb 18, 2025 · 3 comments · May be fixed by #11060
Assignees
Labels
bug Something isn't working

Comments

@dckc
Copy link
Member

dckc commented Feb 18, 2025

Describe the bug

The connection parameters we used - from cosmos/chain-registry - seem to be incorrect. We specified connection-72 for the controller and connection-40 for the host.

'noble-1': {
id: 'connection-72',
client_id: '07-tendermint-77',
counterparty: {
client_id: '07-tendermint-32',
connection_id: 'connection-40',
},

It seems we should’ve used connection-38 for the host per map of zones

As a result, while @0xpatrickdev was able to deposit and withdraw to the LP and see the pool and settlement account addresses published, our request for a Noble ICA is stuck.

const addr = await E(kit.creatorFacet).connectToNoble();

To Reproduce

  1. agd query ibc channel end icacontroller-1 channel-157 --node https://agoric-rpc.polkachu.com:443
  2. see STATE_INIT

Also:

$ agd query ibc connection end connection-72 --node https://agoric-rpc.polkachu.com:443
connection:
  client_id: 07-tendermint-77
  counterparty:
    client_id: 07-tendermint-32
    connection_id: connection-38

Expected behavior

I'm not sure

Platform Environment

  • what OS are you using? what version of Node.js?
  • is there anything special/unusual about your platform?
  • what version of the Agoric-SDK are you using? (run git describe --tags --always)

Additional context

Add any other context about the problem here.

Screenshots

If applicable, add screenshots to help explain your problem, especially for UI interactions.

@dckc dckc added the bug Something isn't working label Feb 18, 2025
@dckc
Copy link
Member Author

dckc commented Feb 18, 2025

See also pc/fusdc-beta-2.

@dckc
Copy link
Member Author

dckc commented Feb 18, 2025

@dckc dckc self-assigned this Feb 18, 2025
mergify bot added a commit that referenced this issue Feb 27, 2025
refs: #11013

## Description

- feat(fast-usdc): `ChainHub` update interfaces
- fix(fast-usdc): prepare to repair Noble Account
- feat(fast-usdc): core eval to update chainInfo, noble ICA
  - feat(builders): to reconfigure Fast USDC
- test(boot): start fastUsdc using fast-usdc-beta-1 release
  - chore(boot): cache fast-usdc-beta-1 release artifacts
- test(boot): upgrade Fast USDC; update noble ICA
- test(boot): oracles accept before upgrade

### Security Considerations

~~`creatorFacet.getChainHub()` increases the surface area of the contract.~~

### Scaling Considerations

none, I think.

### Testing Considerations

 - unit tests for chainHub methods
 - bootstrap test for upgrade

for a later PR:
  - a3p, multichain-testing: #11060

### Upgrade / Documentation Considerations

OCW operators have to accept their invitations before the upgrade, since their invitations are attached to ephemeral offer handlers. Consideration of addressing that is postponed to...

 - #11057
@dckc
Copy link
Member Author

dckc commented Feb 28, 2025

CORE_EVAL failed on upgrade is benign

As noted above, the Beta core eval is awaiting a promise from the fastUsdc contract:

const addr = await E(kit.creatorFacet).connectToNoble();

When the contract is upgraded, that promise will reject, resulting in a rejection of the promise for the CORE_EVAL execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant