Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update feeConfig.variableRate to 0.5%, i.e. 5n/1000n #11054

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: Update feeConfig.variableRate to 0.5%, i.e. 5n/1000n #11054

wants to merge 2 commits into from
+62 −25

Conversation

dckc
Copy link
Member

@dckc dckc commented Feb 26, 2025 •
edited
Loading

Security / Scaling / Documentation Considerations

lowering the rate changes the incentives a bit: it encourages users while rewarding liquidity providers less on each tx

The fees and such should be discussed in the community governance thread.

Testing Considerations

updated relevant snapshot

Upgrade Considerations

deploys with...

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2025 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9537828
Status: ✅  Deploy successful!
Preview URL: https://8bf48287.agoric-sdk.pages.dev
Branch Preview URL: https://dc-fu-feeconfig.agoric-sdk.pages.dev

View logs

@dckc dckc force-pushed the dc-noble-conn branch 4 times, most recently from e96a95a to b140a23 Compare February 27, 2025 03:19
@dckc dckc mentioned this pull request Feb 27, 2025
Merged
@dckc dckc force-pushed the dc-noble-conn branch 2 times, most recently from ebf1bd7 to 07f3dae Compare February 27, 2025 20:33
Base automatically changed from dc-noble-conn to master February 27, 2025 21:21
@dckc dckc marked this pull request as ready for review February 27, 2025 23:11
@dckc dckc requested a review from a team as a code owner February 27, 2025 23:11
0xpatrickdev
0xpatrickdev previously approved these changes Feb 27, 2025
View reviewed changes
packages/boot/test/fast-usdc/snapshots/fast-usdc.test.ts.md Outdated
@@ -243,7 +243,7 @@ Generated by [AVA](https://avajs.dev).
{
encumberedBalance: {
brand: Object @Alleged: USDC brand {},
value: 0n,
value: 750000n,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why this changed 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait... does this mean that an advance didn't finish?

Copy link
Member

@0xpatrickdev 0xpatrickdev Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or we didn't simulate a settle somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contract is restarted in the middle of the test using...

  const kit = await EV.vat('bootstrap').consumeItem('fastUsdcKit');
  const actual = await EV(kit.adminFacet).restartContract(kit.privateArgs);

and the privateArgs in fastUsdcKit weren't updated with the new feeConfig

@dckc dckc marked this pull request as draft February 28, 2025 08:54
@dckc dckc dismissed 0xpatrickdev’s stale review February 28, 2025 08:54

critical problem found

@dckc
Copy link
Member Author

dckc commented Feb 28, 2025

I think the revised connection info should go into privateArgs too, but this one is green now, so I guess I'll try to land it as is and do that in one of the remaining PRs.

@dckc dckc marked this pull request as ready for review February 28, 2025 16:57
@dckc dckc requested a review from 0xpatrickdev February 28, 2025 16:57
@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Feb 28, 2025
0xpatrickdev
0xpatrickdev approved these changes Feb 28, 2025
View reviewed changes
packages/fast-usdc/src/update-noble-ica.core.js

const { brand: usdcBrand } = kitPre.privateArgs.feeConfig.flat;
// TODO: update agoricToNoble in kitPost.privateArgs.chainInfo too
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this matter? It looks like privateArgs.(chainInfo|assetInfo) is only consumed by ChainHub if it's the first incarnation.

Maybe worth a comment in meta.privateArgsShape above these two fields mentioning this.

Copy link
Member Author

@dckc dckc Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a GTM correctness issue, but I was burned once by expecting fastUsdcKit.privateArgs to be current.

packages/boot/test/fast-usdc/snapshots/fast-usdc.test.ts.md
Comment on lines +192 to +196
value: 1000n,
},
numerator: {
brand: Object @Alleged: USDC brand {},
value: 1n,
value: 5n,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dckc dckc mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xpatrickdev 0xpatrickdev 0xpatrickdev approved these changes

@AgoricTriage AgoricTriage Awaiting requested review from AgoricTriage AgoricTriage is a code owner automatically assigned from Agoric/engprodexec

@turadg turadg Awaiting requested review from turadg

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dckc @0xpatrickdev