footer #105
footer #105
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds footer content to the base HTML template, specifically adding an SRE section with a link to failing DAGs in the Astronomer cloud platform.
- Reformats an existing CSS link for better readability
- Condenses the main content block to a single line
- Adds footer content with an SRE section containing a "Failing DAGs" link
Comments suppressed due to low confidence (1)
| <footer class="container"></footer> | ||
| <main class="container">{% block content %}{% endblock %}</main> | ||
| <footer class="container"> | ||
| <p> |
There was a problem hiding this comment.
The h6 element should not be nested inside a p element. Heading elements cannot be children of paragraph elements according to HTML standards.
| <p> |
| href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active" | ||
| >Failing DAGs</a | ||
| > | ||
| </li> |
There was a problem hiding this comment.
Inconsistent indentation with mixed spaces and tabs. The line contains both tab and space characters which can cause formatting issues.
| </li> | |
| </li> |
|
|
||
| <li> | ||
| <a | ||
| href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active" |
There was a problem hiding this comment.
External link should include rel="noopener noreferrer" for security to prevent the target page from accessing the window.opener property and potential tabnabbing attacks.
| href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active" | |
| href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active" rel="noopener noreferrer" |
No description provided.