Skip to content

footer #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redreceipt merged 1 commit into from
Aug 8, 2025
Merged

footer #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="color-scheme" content="light dark" />
<link rel="stylesheet" href="{{ url_for('static', filename='pico.min.css') }}" />
<link
rel="stylesheet"
href="{{ url_for('static', filename='pico.min.css') }}"
/>
<title>{% block title %}{% endblock %}</title>
{% block extra_head %}{% endblock %}
</head>
Expand All @@ -20,10 +23,21 @@
{% block header_nav %}{% endblock %}
</nav>
</header>
<main class="container">
{% block content %}{% endblock %}
</main>
<footer class="container"></footer>
<main class="container">{% block content %}{% endblock %}</main>
<footer class="container">
<p>
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The h6 element should not be nested inside a p element. Heading elements cannot be children of paragraph elements according to HTML standards.

Suggested change
<p>

Copilot uses AI. Check for mistakes.
<h6>SRE</h6>
<ul style="list-style: none; padding-left: 0;">

<li>
<a
href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active"
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External link should include rel="noopener noreferrer" for security to prevent the target page from accessing the window.opener property and potential tabnabbing attacks.

Suggested change
href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active"
href="https://cloud.astronomer.io/cljsvo8d800yz01giqt70a7e7/dags?status=failed&state=active" rel="noopener noreferrer"

Copilot uses AI. Check for mistakes.
>Failing DAGs</a
>
</li>
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with mixed spaces and tabs. The line contains both tab and space characters which can cause formatting issues.

Suggested change
</li>
</li>

Copilot uses AI. Check for mistakes.
</ul>
</p>
</footer>
{% block extra_scripts %}{% endblock %}
</body>
</html>
</html>