Core: limit depth of received JSON to 16 - #6378
Merged
black-sliver merged 3 commits intoAug 10, 2026
Merged
Conversation
This applies to both MultiServer and CommonClient. This means DataStorage default is limited to 14 levels, DataStorage op arg is limited to 13 levels.
|
this doesn't handle backslash-escaped quotes, and mismatched backslash-escaped quotes go particularly badly:
|
Member
Author
|
Oh, true. Why did i forget about this? :/ I blame the summer. |
Berserker66
approved these changes
Aug 8, 2026
Member
Author
|
Some notes on the cython implementation:
|
Berserker66
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Limits the maximum depth of a received JSON document to 16.
This applies to both MultiServer and CommonClient.
This means DataStorage default is limited to 14 levels, DataStorage op arg is limited to 13 levels.
How was this tested?
Unit tests.