Handle case where mem_size_actual is 0 #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dberlin
force-pushed
the
m3-work-mem-size-actual
branch
from
5da75c2
to
897ccc3
Compare
marcan
reviewed
Dec 3, 2023
dberlin
force-pushed
the
m3-work-mem-size-actual
branch
from
ec430cd
to
f123077
Compare
On newer machines, mem_size_actual is 0. This patch cooks up a value when that is the case, and shoves it in the right place. Without this MMU/etc hang on M3 due to not mapping the right region. Signed-off-by: Daniel Berlin <[email protected]>
dberlin
force-pushed
the
m3-work-mem-size-actual
branch
from
f123077
to
1f75f4d
Compare
|
This should now be correct |
|
on j504 (M3 Macbook Pro 14-inch) I see |
marcan
force-pushed
the
main
branch
3 times, most recently
from
4f95305
to
95d67cf
Compare
|
Looks like this is an issue with bootargs version/size then? |
|
Should be supeseded by #403. |
yes, it was. Complicated by the fact that early iboot versions on M3 devices did use revision 2 but used the longer command line length. Missing from #403 is updating |
|
also missing from #403 is replicating the correction of mem_size_actual (which I understand is for these old iBoot versions) in python side, since we're no longer patching the original bootargs and python sees 0 |
mildsunrise
added a commit
to mildsunrise/m1n1
that referenced
this pull request
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case of no mem_size_actual
On newer machines, mem_size_actual is 0.
In this case, we need to use mem_size and mask to a page boundary.
This fixes MMU crash/hang on m3