Skip to content

Conversation

@cojennin
Copy link
Contributor

@cojennin cojennin commented Dec 4, 2019

Dockerizes testing on Travis (and locally) based on Gutenberg.

Adds an E2E test to confirm E2E testing works and the plugin is loaded.

@cojennin cojennin requested review from dchymko and mjangda December 4, 2019 15:01
@cojennin cojennin force-pushed the update/dockerize-testing branch 2 times, most recently from 6d53ffd to 3df4563 Compare December 4, 2019 15:08
@cojennin
Copy link
Contributor Author

cojennin commented Dec 4, 2019

The E2E test will continue to fail until #560 is merged in, the E2E tests delete all posts before running the tests, but the delete action is throwing a WSOD because of the notice from #560 (see screenshot) which prevents the E2E tests from completing (causing the failure)

Screen Shot 2019-12-04 at 9 51 10 AM

@cojennin cojennin mentioned this pull request Dec 4, 2019
@cojennin cojennin force-pushed the update/dockerize-testing branch from 3df4563 to 322e4c6 Compare December 10, 2019 22:02
@cojennin cojennin force-pushed the update/dockerize-testing branch 5 times, most recently from 1a02038 to f7c56e4 Compare December 13, 2019 03:39
@cojennin
Copy link
Contributor Author

Includes a quick update to some tests that were causing test failures in PHPUnit

@cojennin cojennin force-pushed the update/dockerize-testing branch from f7c56e4 to 6fc60de Compare December 13, 2019 21:26
mjangda
mjangda previously approved these changes Dec 18, 2019
Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Spotted one small thing.

@cojennin
Copy link
Contributor Author

cojennin commented Jan 2, 2020

Made the small change @mjangda suggested (tiny tweak to package.json), approval got wiped out but should still be good to merge so we can move forward on adding e2e testing to PR's like #563 and #555

@cojennin cojennin merged commit ecbcd6e into master Jan 2, 2020
@cojennin cojennin deleted the update/dockerize-testing branch January 29, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants