Update notification UI #563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojennin
force-pushed
the
update/fix-author-notification
branch
from
90a91b0 to
d62781e
Compare
cojennin
force-pushed
the
update/fix-author-notification
branch
from
728e000 to
90efe3e
Compare
cojennin
force-pushed
the
update/fix-author-notification
branch
5 times, most recently
from
6adc331 to
161ef48
Compare
cojennin
force-pushed
the
update/fix-author-notification
branch
6 times, most recently
from
af263ca to
a2730fe
Compare
cojennin
force-pushed
the
update/fix-author-notification
branch
from
88cf046 to
0cf07d6
Compare
cojennin
force-pushed
the
update/fix-author-notification
branch
from
0cf07d6 to
ac16904
Compare
Contributor
|
Closing this PR as stale due to significant codebase changes since it was opened in December 2019. Why this can't be easily rebasedThis PR was built on top of #519, which was closed with the comment "continued in #563" rather than being merged. This means #563 contains commits that were never merged to develop, making a clean rebase impossible without significant rework. Changes since this PR was opened
The underlying issueIssue #508 (Unsubscribing author from Notifications is impossible) remains open. The core functionality this PR aimed to provide will be reimplemented fresh on current develop:
Thank you @cojennin and @mikeyarce for the original work on this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some additional work on top of #519 to improve the notifications UI to make it apparent when a user is being auto-subscribed to a post, when they're the post author, when they will be notified but won't have access to a post and when they don't have an email (and thus won't be notified).
I made some adjustments to the UI to adjust for the additional badges that are being applied, see the screenshot below.
I also modified the webpack config to start compiling the module code (starting with notifications, will migrate the rest over on a case by case basis)
It'd be great if we could merge #560 and then #562 so I can write a few E2E tests for this functionality, seems like a strong candidate for it.