-
Notifications
You must be signed in to change notification settings - Fork 235
test: tool to check the lists of linters in lint_group.rs and mod.rs
#2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hippietrail
wants to merge
15
commits into
Automattic:master
Choose a base branch
from
hippietrail:check-linters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+428
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I've been thinking of a tool to make sure all the linter lines in
linting/mod.rsandlinting/lint_group.rsarestructvsexprcorrectlyThis is a start on that. It's already helped me spot things that look wrong.
For instance:
In
linting/mod.rs. And inlinting/lint_group.rs:and:
No other mentions of
call_themorCallThem!Is it an experiment that got staged by accident with some other linter's PR? Or were the missing lines in those two files an unnoticed mistake? Note that these are kinds of errors that the Rust compiler and the unit tests do not pick up!
I actually thought there was another linter that overlapped with this
CallThemthat handled other pronoun or NP cases, but maybe that's one of my unfinished experiment? (-:Note that I'm not sure the best way to check
insert_struct_rulevsinsert_expr_ruleyet but when I started manually checking through the list I think I stopped after seeing at least four that were wrong.Any idea or other feedback appreciated!
Demo
How Has This Been Tested?
Manually
Checklist