Skip to content

Conversation

@hippietrail
Copy link
Collaborator

Issues

N/A

Description

While working on my lint checker I noticed that some linters were missing their pub use lint in linting/mod.rs yet they still worked.
Investigating turned up that I could comment out most of the remaining ones without breaking functionality.
Of the ones that I couldn't comment out, some are part of the linting infrastructure rather than individual linters. But others were just due to the test modules of those linters using inconsistent methods to use their linters. Changing those from use::crate::linting:FooBar to use super::FooBar in line with the majority of linters made it possible to comment out most of those too.

For new contributors this means one less step in developing their first linter. And should reduce confusion regarding why some linters did things in different ways.

Demo

How Has This Been Tested?

All tests still pass.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

Copy link
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. In the beginning, I had this idea that downstream consumers of harper-core would want access to the individual rules. That clearly hasn't been the case beyond what is available as configuration on the curated LintGroup.

@elijah-potter elijah-potter added this pull request to the merge queue Nov 28, 2025
Merged via the queue into Automattic:master with commit 0889bf0 Nov 28, 2025
11 checks passed
@hippietrail hippietrail deleted the more-consistent-linters branch November 28, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants