-
Notifications
You must be signed in to change notification settings - Fork 819
Jetpack SEO: Ensure more performant practices when getting enabled features. #43031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works perfectly, thanks @coder-karen
Fixes #43033
Proposed changes:
getEnabledFeatures
works by making sure we only run the selector function if the dependencies have changed.useSelect
warning in the console of post editors (when script debug is enabled, running WordPress 6.8):Other information:
Jetpack product discussion
p1744303609023589-slack-C02TQF5VAJD
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
This may need expansion, but:
If you spin up a Jurassic Ninja site using the Jetpack Beta tester plugin (testing in bleeding edge), and also install the WordPress Beta Tester plugin, with Jetpack connected you should be able to replicate the console warning if opening up a post. You will also need script debug enabled in
wp-config.php
:define( 'SCRIPT_DEBUG', 'true' );
.With this PR applied, the warning no longer appears.
To confirm no impact on features, activate SEO from the SEO panel (in the Jetpack sidebar), and 'generate metadata'.