Forms: Fix the loading state to prevent an empty state flash

[lezama]

Summary

Improves loading state logic to show spinner immediately when data hasn't resolved yet, preventing empty state flash before data loads.

Changes

• Changed loading condition from isResolving to !rawRecords?.length && !hasResolved
• Shows loading spinner immediately if no data and not yet resolved
• Prevents jarring empty state → loading → content transition

UX Impact

• Smoother perceived performance
• No visual flash of empty state
• Loading spinner appears immediately when expected

Related

Main PR: #45339

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• 🔴 Add testing instructions.
  
• 🔴 Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

---

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/optimize-inbox-loading-state branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack forms/optimize-inbox-loading-state

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/hooks/use-inbox-data.ts	22/28 (78.57%)	0.79%	0 💚

Full summary · PHP report · JS report

[edanzer]

Is there anything I need to do to see/duplicate the 'flash' issue? I'd like to confirm the issue before testing the fix, but I don't typically see a flash when the form responses page loads.

[CGastrell]

Code looks good, but I can't be sure it solves anything as I fail to understand the issue in the first place. If you feel confident about it, merge it, otherwise let me know how can we observe/verify the issue and improvement.

[lezama]

@CGastrell @edanzer I see a brief “No responses” message before the spinner without this PR. It might be my setup or connection. This PR fixes it.