[ARM] az deployment: Fix the bug of 'bytes' object has no attribute 'get' for error handling in retry cases

[zhoxing-ms]

Issue: #19743

Description

This error bytes' object has no attribute 'get' is due to the bug of JsonCTemplatePolicy in the retry operation.
In the case of retry, because the first request has been processed and converted the type of request.http_request.data from string to bytes code link , so there is no need to process request.http_request.data again during retry,

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[yonzhan]

ARM

[jsntcy]

@zhoxing-ms, have we run all tests impacted by this logic?

[zhoxing-ms]

It mainly runs the tests that affects the scope of resource group. The logic of other scopes (such as: tenant sub mg) calling this policy is the same, so the scope of resource group can basically cover all use cases~

[jiasli]

The purpose and logic of JsonCTemplatePolicy is hard to understand.

It seems JSONSerializer wraps the jsonc in a JsonCTemplate and then JsonCTemplatePolicy extracts the jsonc. Why isn't the jsonc serialization logic

azure-cli/src/azure-cli/azure/cli/command_modules/resource/custom.py

Line 432 in 899f18c

http_request.data = partial_request[:-2] + ", template:" + template.template_as_bytes + r"}}"

done in JSONSerializer?

Also, The name template_as_bytes is misleading (#10389 (comment)).

We need better comments!

[zhoxing-ms]

It seems JSONSerializer wraps the jsonc in a JsonCTemplate and then JsonCTemplatePolicy extracts the jsonc. Why isn't the jsonc serialization logic done in JSONSerializer?

In fact, it's technically feasible. I've tried it and it works fine. I guess this may be a decision in code design. Maybe this splicing is not appropriate to put it in the serialization logic in code design.
Because this is legacy code, I can't answer this question perfectly. 😂

Also, The name template_as_bytes is misleading (#10389 (comment)).

I agree! It will be converted to bytes in the subsequent step of JsonCTemplatePolicy, but not in the step of JSONSerializer. So I submitted a PR #21991 to correct the variable name and add some comments to explain the function of JsonCTemplatePolicy