{ARM} Add comments for JsonCTemplatePolicy #21991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
added
the
ARM
Collaborator
|
ARM |
3 tasks
jsntcy
approved these changes
Apr 18, 2022
zhoxing-ms
force-pushed
the
refine_jsonctemplate_policy
branch
from
f675543 to
d00873d
Compare
zhoxing-ms
commented
Apr 21, 2022
Comment on lines
-392
to
+393
| def __init__(self, template_as_bytes): | ||
| self.template_as_bytes = template_as_bytes | ||
| def __init__(self, template_string): | ||
| self.template_string = template_string |
Contributor
Author
There was a problem hiding this comment.
The template_as_bytes will be converted to bytes in the subsequent step of JsonCTemplatePolicy, but not in the step of JSONSerializer. So correct the variable name to avoid misleading
Member
There was a problem hiding this comment.
data is ambiguous. It can mean object or string. Let's call it template_str.
jiasli
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion on #21220 (comment)
Add some comments to explain the function of
JsonCTemplatePolicyand fix incorrect variable nametemplate_as_bytesTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.