[AKS] aks enable-addons: Add new parameter --enable-msi-auth-for-monitoring to support enabling managed identity auth
#21661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested a review
from 
ganga1980
changed the title
ganga1980
changed the title
ganga1980
changed the title
Collaborator
|
AKS |
Contributor
Author
|
Hi, @andyliuliming , @jsntcy , @kairu-ms , can one of you please review this PR? |
zhoxing-ms
approved these changes
Mar 23, 2022
zhoxing-ms
changed the title
aks enable-addons: Add new parameter --enable-msi-auth-for-monitoring to support enabling managed identity auth
Contributor
|
@ganga1980 I modified the PR title, please see if it's description is accurate |
Contributor
Author
|
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
kairu-ms
approved these changes
Mar 25, 2022
jiasli
reviewed
Mar 28, 2022
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| import importlib | ||
| from tkinter import FALSE |
Member
There was a problem hiding this comment.
This line breaks CI and it is never used:
==================================== ERRORS ====================================
_______________ ERROR collecting tests/latest/test_decorator.py ________________
ImportError while importing test module '/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/acs/tests/latest/test_decorator.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.6/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/acs/tests/latest/test_decorator.py:7: in <module>
from tkinter import FALSE
E ModuleNotFoundError: No module named 'tkinter'
Contributor
There was a problem hiding this comment.
@ganga1980 May I ask why this unused import was added here?
Contributor
Author
There was a problem hiding this comment.
@ganga1980 May I ask why this unused import was added here?
@zhoxing-ms , Not sure why this got added automatically. please go-ahead and remove this unused import.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces additional flag --enable-msi-auth-for-monitoring for customer to enable AKS monitoring addon with managed identity auth
Testing Guide
az aks create -g
<rgName>-n<clusterName>--enable-addons monitoring --enable-msi-auth-for-monitoring --generate-ssh-keysaz aks enable-addons -a monitoring -g
<rgName>-n<clusterName>--enable-msi-auth-for-monitoringHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.