{AKS} Remove from tkinter import FALSE to unblock CI
#21823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
assigned
jiasli
changed the title
from tkinter import FALSEfrom tkinter import FALSE to unblock CI
zhoxing-ms
approved these changes
Mar 28, 2022
jiasli
commented
Mar 28, 2022
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| import importlib | ||
| from tkinter import FALSE |
Member
Author
There was a problem hiding this comment.
The import error is only found on
- Test Rpm Package
- Test Deb Packages Focal
- Test Deb Packages Buster
but not on
- Automation Test (Profile Latest) Python310
This is because we don't include tkinter in our built Python in order to save package size:
The necessary bits to build these optional modules were not found:
_bz2 _curses _curses_panel
_dbm _gdbm _lzma
_sqlite3 _tkinter readline
To find the necessary bits, look in setup.py in detect_modules() for the module's name.
CentOS 7's python also has no tkinter.
On the other hand, ADO's Python has tkinter.
Collaborator
|
AKS |
jsntcy
approved these changes
Mar 28, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
calvinhzy
approved these changes
Mar 29, 2022
Member
Author
|
#21821 includes this change and precedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#21661 added this unused line for unknown reason and it breaks CI (#21661 (comment)).
Remove it to unblock CI.