Skip to content

Conversation

@navba-MSFT
Copy link
Contributor

@navba-MSFT navba-MSFT commented Mar 22, 2022

Fixes #21728 .
Addition to description of list-runtime command.

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Fixes #21728 .
Addition to description of list-runtime command.
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 22, 2022
@ghost ghost assigned zhoxing-ms Mar 22, 2022
@ghost ghost added this to the Mar 2022 (2022-04-06) milestone Mar 22, 2022
@ghost ghost requested a review from yonzhan March 22, 2022 08:43
@ghost ghost added the Web Apps az webapp label Mar 22, 2022
@ghost ghost requested a review from wangzelin007 March 22, 2022 08:43
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 22, 2022

webapp

@StrawnSC StrawnSC self-requested a review March 22, 2022 17:57
Copy link
Contributor

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navba-MSFT I recently made the change to use the colon delimiter (":") instead of the pipe ("|") because the pipe was causing issues for PowerShell users (it has to be escaped in a particular way)
The fix here should be to keep all the documentation as is (recommending users use the colon), but to change the az webapp github-actions add implementation to replace the colon with a pipe in the --runtime argument (as we do elsewhere in the code)

@navba-MSFT
Copy link
Contributor Author

Closing this PR as the fix will be done on other PR #21771

@navba-MSFT navba-MSFT closed this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Web Apps az webapp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtimes documentation slightly misleading

4 participants