[App Service] Fix #21728: az webapp deployment github-actions add: Allow passing in runtime with colon delimiter
#21771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrawnSC
requested review from
jsntcy,
panchagnula and
zhoxing-ms
as code owners
ghost
added
the
ghost
requested review from
StrawnSC
changed the title
az webapp deployment github-actions add: Fix #21741: Allow passing in runtime with colon delimiteraz webapp deployment github-actions add: Fix #21728: Allow passing in runtime with colon delimiter
Collaborator
|
App Service |
wangzelin007
approved these changes
Mar 24, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
@calvinsID can you review the PR. @StrawnSC is there a mock test we can add to ensure that we catch such issues in the future? |
Contributor
Author
|
@panchagnula we don't have any mocked tests covering |
zhoxing-ms
changed the title
az webapp deployment github-actions add: Fix #21728: Allow passing in runtime with colon delimiteraz webapp deployment github-actions add: Allow passing in runtime with colon delimiter
Contributor
|
@StrawnSC Could you please resolve those CI issues? |
3 tasks
zhoxing-ms
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21728
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.