Skip to content

{AKS} Remove from tkinter import FALSE to unblock CI #21823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Mar 29, 2022
Merged

{AKS} Remove from tkinter import FALSE to unblock CI #21823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# --------------------------------------------------------------------------------------------

import importlib
from tkinter import FALSE
Copy link
Member Author

@jiasli jiasli Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import error is only found on

  • Test Rpm Package
  • Test Deb Packages Focal
  • Test Deb Packages Buster

but not on

  • Automation Test (Profile Latest) Python310

This is because we don't include tkinter in our built Python in order to save package size:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1464021&view=logs&j=2cfc7b5c-b945-5758-720c-434c292791a8&t=e70effe3-d4e7-5613-ef4d-26b0b8e6ed67&l=2392

The necessary bits to build these optional modules were not found:
_bz2                  _curses               _curses_panel      
_dbm                  _gdbm                 _lzma              
_sqlite3              _tkinter              readline           
To find the necessary bits, look in setup.py in detect_modules() for the module's name.

CentOS 7's python also has no tkinter.

On the other hand, ADO's Python has tkinter.

import unittest
from unittest.mock import Mock, call, patch

Expand Down