Remove swagger check from CI #2706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
This was referenced May 20, 2025
Member
|
This is true for data plane, but not yet true for management plane, unless I am missing something |
markcowl
reviewed
May 21, 2025
| - template: /eng/pipelines/jobs/website.yml | ||
|
|
||
| - template: /eng/pipelines/jobs/e2e-job.yml@self | ||
| - job: AutorestChecks |
Member
There was a problem hiding this comment.
I believe that this is still used by management plane sdks, especially for updates to existing specs.
Member
Author
There was a problem hiding this comment.
they still go typespec -> swagger -> autorest -> client for management plane?
Member
There was a problem hiding this comment.
Can we please make a call on this soon, to unblock #2705?
Member
Author
There was a problem hiding this comment.
ok I upgraded core and the extensions in that check in your pr and I think this fixed the issue. So this PR is not needed for now at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is uncessary now, as none of the generated swagger should be used to generate SDK via autorest. We just need to make sure the swagger doesn't change unexpectedly which is caught in many other ways.