Skip to content

Remove swagger check from CI #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timotheeguerin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove swagger check from CI #2706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions eng/pipelines/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,4 @@ extends:
- template: /eng/pipelines/jobs/website.yml

- template: /eng/pipelines/jobs/e2e-job.yml@self
- job: AutorestChecks
Copy link
Member

@markcowl markcowl May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this is still used by management plane sdks, especially for updates to existing specs.

Copy link
Member Author

@timotheeguerin timotheeguerin May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they still go typespec -> swagger -> autorest -> client for management plane?

Copy link
Member

@mikeharder mikeharder Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please make a call on this soon, to unblock #2705?

Copy link
Member

@mikeharder mikeharder Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timotheeguerin: Ping

Copy link
Member Author

@timotheeguerin timotheeguerin Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I upgraded core and the extensions in that check in your pr and I think this fixed the issue. So this PR is not needed for now at least

displayName: "Autorest Checks"
pool:
name: $(LINUXPOOL)
image: $(LINUXVMIMAGE)
os: linux

steps:
- template: /eng/pipelines/templates/swagger-checks.yml@self
parameters:
nodeVersion: 20.x
- template: /eng/pipelines/jobs/publish-artifacts.yml@self
23 changes: 0 additions & 23 deletions eng/pipelines/templates/swagger-checks.yml
View file
Open in desktop

This file was deleted.

Loading