[Performance] optimize logging on cache hit path #14481
Draft
+204
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bobronium
commented
Sep 12, 2025
| @@ -2893,19 +2854,13 @@ def _get_assembled_streaming_response( | |||
| ResponseCompletedEvent, | |||
| Any, | |||
| ], | |||
| start_time: datetime.datetime, | |||
There was a problem hiding this comment.
I've checked that _get_assembled_streaming_response is not used anywhere else, and I doubt anyone would subclass and redefine it
Bobronium
commented
Sep 12, 2025
| callbacks = self.get_combined_callback_list( | ||
| dynamic_success_callbacks=self.dynamic_async_success_callbacks, | ||
| global_callbacks=litellm._async_success_callback, | ||
| ) | ||
|
|
||
| result = redact_message_input_output_from_logging( |
There was a problem hiding this comment.
Done once in helper
Bobronium
force-pushed
the
litellm_/performance/deduplicate_success_logging
branch
from
197d870 to
84299f4
Compare
Bobronium
force-pushed
the
litellm_/performance/deduplicate_success_logging
branch
from
84299f4 to
8a048c9
Compare
_get_assembled_streaming_response is not used anywhere except these two places I doubt that any code that subclasses this function exists and expects full range of defined attributes, still this change may be reverted in case any concerns will be raised.
…tly once on cache hits
Bobronium
force-pushed
the
litellm_/performance/deduplicate_success_logging
branch
from
8a048c9 to
b781136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitImpact
Before
After
Type
🧹 Refactoring
⏱️ Performance
✅ Test
Changes