-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(ollama): Handle non-tool-call JSON response when format=json #9966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arjunprabhulal
wants to merge
4
commits into
BerriAI:main
Choose a base branch
from
arjunprabhulal:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…move debug prints
…move debug prints and comment
Here is full code repo for above fix to work with external third party tools like with ADK - Function calling with Ollama/gemma3:27B and Ollama/llama3.2:latest and other models https://github.com/arjunprabhulal/adk-gemma3-function-calling |
@ishaan-jaff - Please take a look at this and happy to provide more information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fix(ollama): Handle non-tool-call JSON response when format=json
Issue occurs while using from google.adk.models.lite_llm import LiteLlm with llama3.2 , gemma3:27b
Error
Changes
This PR addresses a KeyError: 'name' that occurs in litellm/llms/ollama/completion/transformation.py when using certain Ollama models (e.g., ollama/llama3.2:latest, ollama/gemma3:27b) with tool calling enabled (format="json").
Problem:
When LiteLLM expects a tool call response, it requests format="json" from Ollama. However, some models return a valid JSON string in the response field, but the structure of this JSON does not match the expected tool call format ({"name": ..., "arguments": ...}). Instead, it might contain other structures (e.g., Schema.org JSON as seen with llama3.2). When transformation.py parses this JSON and attempts to access function_call["name"], it results in a KeyError.
