fix: skip combineSigShare check for non-EIP191 message signing #6686
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavidhingra
force-pushed
the
coin-5225-skip-combineSigShare-check-for-non-eip191-msg-signing
branch
from
26a1214 to
d09bd9d
Compare
hrishikeshjain
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the
Walletclass to improve message signing validation for Ethereum-family coins. Specifically, it adds a check to ensure thatcombineSigShareis present in the signed message request when the coin family is Ethereum.Validation improvements for Ethereum-family coins:
Walletclass to assert the presence ofcombineSigShareinsignedMessageRequest.messagesonly for coins in the Ethereum family, using theCoinFamilyenum.CoinFamilyfrom@bitgo/staticsto support the new conditional logic.TICKET: COIN-5225